Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf readability refactors 2019 08 28 #32370

Closed
wants to merge 2 commits into from
Closed

Perf readability refactors 2019 08 28 #32370

wants to merge 2 commits into from

Conversation

pkozlowski-opensource
Copy link
Member

No description provided.

@pkozlowski-opensource pkozlowski-opensource force-pushed the perf_readability_refactors_2019_08_28 branch from a4df9b1 to a440a4d Compare August 28, 2019 13:53
@pkozlowski-opensource pkozlowski-opensource force-pushed the perf_readability_refactors_2019_08_28 branch from a440a4d to 4327b92 Compare August 28, 2019 14:14
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review August 28, 2019 15:45
@pkozlowski-opensource pkozlowski-opensource requested a review from a team as a code owner August 28, 2019 15:45
@atscott atscott added area: core Issues related to the framework runtime comp: ivy labels Aug 28, 2019
@ngbot ngbot bot added this to the needsTriage milestone Aug 28, 2019
kara
kara approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: presubmit The PR is in need of a google3 presubmit target: major This PR is targeted for the next major release labels Aug 28, 2019
@kara
Copy link
Contributor

kara commented Aug 28, 2019

VE presubmit

Ivy presubmit

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: presubmit The PR is in need of a google3 presubmit labels Aug 28, 2019
@mhevery mhevery closed this in 1bb9ce5 Aug 29, 2019
mhevery pushed a commit that referenced this pull request Aug 29, 2019
@pkozlowski-opensource @mhevery
refactor(ivy): remove global state access from inputs-related functio…
d4703d9 
…ns (#32370)

PR Close #32370
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@pkozlowski-opensource @sabeersulaiman
refactor(ivy): remove superflous argument to the createTNodeAtIndex f…
73e6ab8 
…unction (angular#32370)

PR Close angular#32370
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@pkozlowski-opensource @sabeersulaiman
refactor(ivy): remove global state access from inputs-related functio…
f71b2d4 
…ns (angular#32370)

PR Close angular#32370
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@pkozlowski-opensource @arnehoek
refactor(ivy): remove superflous argument to the createTNodeAtIndex f…
a33b4df 
…unction (angular#32370)

PR Close angular#32370
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@pkozlowski-opensource @arnehoek
refactor(ivy): remove global state access from inputs-related functio…
1940dc7 
…ns (angular#32370)

PR Close angular#32370
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pkozlowski-opensource @kara @atscott @googlebot